[PATCH] D41949: [RISCV] implement li pseudo instruction

[Mario Werner via Phabricator via llvm-commits]

niosHD marked 5 inline comments as done.
niosHD added a comment.

In https://reviews.llvm.org/D41949#1045516, @asb wrote:

> Thanks Mario. I think this is looking good to land now.


Perfect, thank you for the great feedback!

> Are you planning a follow-up patch that will show `li` in disassembly and for generated assembly in simple cases? (matching binutils more closely).

Yes, I will look into it. Doing the same as binutils should be reasonable simple.

> I haven't looked into it more closely, but I do note a minor codegen change for float-mem.ll which results in an extra instruction:

Good catch, I missed that codegen change. Seems like the ADDI was previously merged into the FLW. Given that we can solely use PseudoLI for constants we probably only miss a simplification pattern or a simple peephole optimisation. I can have a look but given that I currently do not use floating point instructions it may take some time.


https://reviews.llvm.org/D41949