[PATCH] D37256: [Nios2] adding subtarget, basic infrastructure for frame, instructions and registers

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 20 13:34:34 PDT 2017


I've just done this here:

echristo at athyra ~/s/l/l/T/Nios2> git svn dcommit
Committing to https://llvm.org/svn/llvm-project/llvm/trunk ...
M lib/Target/Nios2/Nios2TargetMachine.cpp
M lib/Target/Nios2/Nios2TargetMachine.h
Committed r313808

I didn't see any uses via grep.

-eric

On Tue, Sep 19, 2017 at 9:48 AM Eric Christopher via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:

> echristo added inline comments.
>
>
> ================
> Comment at: llvm/trunk/lib/Target/Nios2/Nios2TargetMachine.h:22
>  class Nios2TargetMachine : public LLVMTargetMachine {
> +  Nios2Subtarget DefaultSubtarget;
> +
> ----------------
> Please don't have a default subtarget. There's no reason to do so and it
> just confuses things.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D37256
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170920/3469dc3b/attachment.html>


More information about the llvm-commits mailing list