<div dir="ltr">I've just done this here:<div><br></div><div><div>echristo@athyra ~/s/l/l/T/Nios2> git svn dcommit</div><div>Committing to <a href="https://llvm.org/svn/llvm-project/llvm/trunk">https://llvm.org/svn/llvm-project/llvm/trunk</a> ...</div><div><span style="white-space:pre">       </span>M<span style="white-space:pre">    </span>lib/Target/Nios2/Nios2TargetMachine.cpp</div><div><span style="white-space:pre">       </span>M<span style="white-space:pre">    </span>lib/Target/Nios2/Nios2TargetMachine.h</div><div>Committed r313808</div></div><div><br></div><div>I didn't see any uses via grep.</div><div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Sep 19, 2017 at 9:48 AM Eric Christopher via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">echristo added inline comments.<br>
<br>
<br>
================<br>
Comment at: llvm/trunk/lib/Target/Nios2/Nios2TargetMachine.h:22<br>
 class Nios2TargetMachine : public LLVMTargetMachine {<br>
+  Nios2Subtarget DefaultSubtarget;<br>
+<br>
----------------<br>
Please don't have a default subtarget. There's no reason to do so and it just confuses things.<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D37256" rel="noreferrer" target="_blank">https://reviews.llvm.org/D37256</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>