[PATCH] D37256: [Nios2] adding subtarget, basic infrastructure for frame, instructions and registers

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 19 09:48:41 PDT 2017


echristo added inline comments.


================
Comment at: llvm/trunk/lib/Target/Nios2/Nios2TargetMachine.h:22
 class Nios2TargetMachine : public LLVMTargetMachine {
+  Nios2Subtarget DefaultSubtarget;
+
----------------
Please don't have a default subtarget. There's no reason to do so and it just confuses things. 


Repository:
  rL LLVM

https://reviews.llvm.org/D37256





More information about the llvm-commits mailing list