[llvm] r311976 - Revert "[codeview] don't try to emit variable locations without registers"

[David Blaikie via llvm-commits]

On Mon, Aug 28, 2017 at 9:09 PM Bob Haarman via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: inglorion
> Date: Mon Aug 28 21:08:16 2017
> New Revision: 311976
>
> URL: http://llvm.org/viewvc/llvm-project?rev=311976&view=rev
> Log:
> Revert "[codeview] don't try to emit variable locations without registers"
>
> This reverts commit a256fbcacf448ee793d23552c46ed2971bf9eff5.
>

Similar (to the other commit) feedback here: Use svn revision numbers and
include info about the motivation for the revert (links to buildbot
failures, etc).


>
> Modified:
>     llvm/trunk/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
>
> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp?rev=311976&r1=311975&r2=311976&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp (original)
> +++ llvm/trunk/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp Mon Aug 28
> 21:08:16 2017
> @@ -988,7 +988,7 @@ void CodeViewDebug::calculateRanges(
>      }
>
>      // If we don't know how to handle this range, skip past it.
> -    if (!Supported || Location.Register == 0 || (Location.Offset &&
> !Location.InMemory))
> +    if (!Supported || (Location.Offset && !Location.InMemory))
>        continue;
>
>      // Handle the two cases we can handle: indirect in memory and in
> register.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170904/c85378d9/attachment.html>