<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Mon, Aug 28, 2017 at 9:09 PM Bob Haarman via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: inglorion<br>
Date: Mon Aug 28 21:08:16 2017<br>
New Revision: 311976<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=311976&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=311976&view=rev</a><br>
Log:<br>
Revert "[codeview] don't try to emit variable locations without registers"<br>
<br>
This reverts commit a256fbcacf448ee793d23552c46ed2971bf9eff5.<br></blockquote><div><br>Similar (to the other commit) feedback here: Use svn revision numbers and include info about the motivation for the revert (links to buildbot failures, etc).<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    llvm/trunk/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp<br>
<br>
Modified: llvm/trunk/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp?rev=311976&r1=311975&r2=311976&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp?rev=311976&r1=311975&r2=311976&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp Mon Aug 28 21:08:16 2017<br>
@@ -988,7 +988,7 @@ void CodeViewDebug::calculateRanges(<br>
     }<br>
<br>
     // If we don't know how to handle this range, skip past it.<br>
-    if (!Supported || Location.Register == 0 || (Location.Offset && !Location.InMemory))<br>
+    if (!Supported || (Location.Offset && !Location.InMemory))<br>
       continue;<br>
<br>
     // Handle the two cases we can handle: indirect in memory and in register.<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>