[PATCH] D36835: [llvm-dwarfdump] Hide .debug_str and die reference offsets in brief mode

[David Blaikie via llvm-commits]

Ping

On Mon, Aug 28, 2017 at 8:20 PM David Blaikie via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:

> dblaikie added inline comments.
>
>
> ================
> Comment at: llvm/trunk/test/tools/llvm-dwarfdump/X86/brief.s:7-10
>  # CHECK: DW_AT
> +# CHECK-NOT: debug_str
> +# CHECK-NOT: DW_AT_type {{.*}} =>
>
> ----------------
> It's probably worth having a positive test for what the string printing
> looks like in brief mode? I know it was mentioned in the patch description,
> but it was revised before committing & I was curious to see how it actually
> prints out now.
>
> FWIW, I'd think we might want to drive towards printing something as
> simple as:
>
>   compile_unit
>     name: "foo"
>
> (ie: dropping as much of the ()[]{} sort of stuff as possible, and
> dropping the DW_*_ prefixes too - since they're unambiguous as to what's a
> DW_TAG, DW_AT, DW_OP, etc, based on context)
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D36835
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170904/e46e4cd4/attachment.html>