[PATCH] D32162: Inline asm 0bH conflict

[Andrew V. Tischenko via Phabricator via llvm-commits]

avt77 added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp:147
   Parser->setTargetParser(*TAP.get());
+  if (Dialect == InlineAsm::AD_Intel) {
+    Parser->setParsingInlineAsm(true);
----------------
craig.topper wrote:
> Can you add an explanatory comment here?
In fact we need here the first line only that tells we're dealing with MS inline asm syntax. The second line is deafult and I can safely remove the one.


================
Comment at: lib/MC/MCParser/AsmParser.cpp:740
   AsmCond StartingCondState = TheCondState;
+  SmallVector<AsmRewrite, 4> AsmStrRewrites;
 
----------------
craig.topper wrote:
> What is this change for?
It's used below in "parseStatement". Without it"parseStatement" crashes.


https://reviews.llvm.org/D32162