[PATCH] D32162: Inline asm 0bH conflict

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 18 23:26:19 PDT 2017


craig.topper added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp:147
   Parser->setTargetParser(*TAP.get());
+  if (Dialect == InlineAsm::AD_Intel) {
+    Parser->setParsingInlineAsm(true);
----------------
Can you add an explanatory comment here?


================
Comment at: lib/MC/MCParser/AsmParser.cpp:740
   AsmCond StartingCondState = TheCondState;
+  SmallVector<AsmRewrite, 4> AsmStrRewrites;
 
----------------
What is this change for?


https://reviews.llvm.org/D32162





More information about the llvm-commits mailing list