[PATCH] D32162: Inline asm 0bH conflict

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/MC/MCParser/AsmParser.cpp:740
   AsmCond StartingCondState = TheCondState;
+  SmallVector<AsmRewrite, 4> AsmStrRewrites;
 
----------------
avt77 wrote:
> craig.topper wrote:
> > What is this change for?
> It's used below in "parseStatement". Without it"parseStatement" crashes.
Should we even allow a ParseStatementInfo default constructor in that case?


================
Comment at: lib/MC/MCParser/AsmParser.cpp:1654
     // Emit the label.
-    if (!ParsingInlineAsm)
+    if (!getTargetParser().isParsingInlineAsm())
       Out.EmitLabel(Sym, IDLoc);
----------------
Please explain why we're using the target parser here and not anywhere else that ParsingInlineAsm is used.


================
Comment at: lib/MC/MCParser/AsmParser.cpp:2065
+                                                  getTargetParser().
+                                                      isParsingInlineAsm()))
       return true;
----------------
clang-format


================
Comment at: test/MC/X86/inline-0bh.ll:4
+
+target triple = "x86_64-unknown-linux-gnu"
+
----------------
please move the triple into the RUN cmd:
```
llc < %s -mtriple=x86_64-unknown-linux-gnu | FileCheck %s
```


https://reviews.llvm.org/D32162