[PATCH] D28723: [libFuzzer] AlrmHandler is executed in a different thread for Windows.
Zachary Turner via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 17 10:16:22 PST 2017
lgtm, I agree that in theory having both codepaths behave the same would be
better, but I guess for now we should just focus on doing the least amount
of work to get things working and tests passing.
On Tue, Jan 17, 2017 at 10:11 AM Marcos Pividori via Phabricator <
reviews at reviews.llvm.org> wrote:
> mpividori added a comment.
> @zturner Yes, I disable the check for `InFuzzingThread()` on Windows,
> because `AlarmCallback()` is always executed on a different thread. If I
> don't add these changes, the alarm handler will never execute.
> As I mentioned in https://reviews.llvm.org/D27240, we could have some
> problems because we don't synchronize with the main thread. But we decided
> to ignore them.
> In fact, we can't fix that because the same function `AlarmCallback()`
> will be called asynchronously for linux, so we can't use locks or anything
> like that.
> rL LLVM
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits