[PATCH] D28723: [libFuzzer] AlrmHandler is executed in a different thread for Windows.

Marcos Pividori via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 17 10:11:24 PST 2017

mpividori added a comment.

@zturner Yes, I disable the check for `InFuzzingThread()` on Windows,  because `AlarmCallback()` is always executed on a different thread. If I don't add these changes, the alarm handler will never execute.

As I mentioned in https://reviews.llvm.org/D27240, we could have some problems because we don't synchronize with the main thread. But we decided to ignore them.
In fact, we can't fix that because the same function `AlarmCallback()` will be called asynchronously for linux, so we can't use locks or anything like that.



More information about the llvm-commits mailing list