[PATCH] D28384: Update update_test_checks to work properly with phi nodes and other fun things.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 07:49:41 PST 2017


RKSimon added a comment.

In https://reviews.llvm.org/D28384#637887, @spatel wrote:

> One thing I would like to note is that I was hoping to unify this script and update_llc_test_checks.py since they're probably still 95% the same thing, but maybe it's best to just specialize this script for 'opt' and let the 'llc' script evolve separately?


I think we're better off enforcing the split between these now - if we're going to get better asm support in for different arch, update_llc_test_checks.py is going to diverge pretty quickly. Its not out of the question to share common code between them if we want to.


https://reviews.llvm.org/D28384





More information about the llvm-commits mailing list