[PATCH] D28384: Update update_test_checks to work properly with phi nodes and other fun things.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 07:36:46 PST 2017


spatel added reviewers: t.p.northover, bryant, zvi, RKSimon, efriedma.
spatel added a comment.

Thanks for working on this!

I made a note to myself that the script didn't work with loops, but I wasn't sure how to fix it. I'm highly unqualified to review because hacking together update_llc_test_checks.py with Tim's 'FileCheck for clang' script is my only experience with python...ever.

One thing I would like to note is that I was hoping to unify this script and update_llc_test_checks.py since they're probably still 95% the same thing, but maybe it's best to just specialize this script for 'opt' and let the 'llc' script evolve separately?


https://reviews.llvm.org/D28384





More information about the llvm-commits mailing list