[PATCH] D28384: Update update_test_checks to work properly with phi nodes and other fun things.

bryant via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 6 08:47:29 PST 2017


bryant added a comment.

drive-by comment.



================
Comment at: utils/update_test_checks.py:176
+      if match.group(1) in vars_seen:
+        line = line.replace('%' + match.group(1), get_value_use(match.group(1)), 1)
+        continue
----------------
You're limiting the number of replaced uses to 1. Can a line have more than one use?


https://reviews.llvm.org/D28384





More information about the llvm-commits mailing list