[PATCH] D27551: [DebugInfo] Add regression test for __fp16, float, and double constants.

David Gross via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 15:24:37 PST 2016

dgross added a comment.

In https://reviews.llvm.org/D27551#620373, @dblaikie wrote:

> Does this need the test coverage if it's just "hey, LLVM can splat these bytes out into DWARF even if we (independently) say the type of those bytes is a float"? The code that emits the bytes is presumably independent of the code that emits the type description, so testing the combination seems unnecessary to me.

Can you explain this further?  What parts of this test case are you suggesting may be unnecessary?


More information about the llvm-commits mailing list