[PATCH] D27551: [DebugInfo] Add regression test for __fp16, float, and double constants.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 12 14:32:03 PST 2016

aprantl added inline comments.

Comment at: test/DebugInfo/Generic/static-const-fp.ll:78
+; CHECK: DW_TAG_variable
+; CHECK-NOT: {{^0}}
+; CHECK: DW_AT_name {{.*}} "hVal"
probinson wrote:
> To verify that the next attribute is part of the same DIE we usually do:
> ```
> ```
> which shows it's not in a child and not in a DIE from a higher nesting level.
Alternatively, you can also use CHECK-NEXT, which is often more readable if the match is expected to be on the next line (but not as flexible).

Comment at: test/DebugInfo/Generic/static-const-fp.ll:4
+; Per PR26619, check that for referenced static const of floating-point type,
+; we emit its constant value in debug info.  NOTE that PR26619 is not yet fixed for long double.
Can you wrap this to 80 columns? clang-format can do this for you.


More information about the llvm-commits mailing list