[PATCH] D25418: [ADT] Add make_pointe{e,r}_iterator.

Tim Shen via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 10 12:01:46 PDT 2016


On Mon, Oct 10, 2016 at 11:51 AM David Blaikie <dblaikie at gmail.com> wrote:

> Perhaps a different phab review? I don't see it in that one (I see
> make_move_iterator used a few times there, though)
>

Are yes, sorry, it should be D25422.

It's used to initialize a SmallVector, which does take a range.


>
> On Mon, Oct 10, 2016 at 11:48 AM Tim Shen <timshen at google.com> wrote:
>
> On Mon, Oct 10, 2016 at 11:31 AM David Blaikie <dblaikie at gmail.com> wrote:
>
> Do you have a use case for this that wouldn't be better off with a
> "make_pointe{e,r}_range"? (perhaps we can skip the make_*_iterator if we
> don't need them, and go straight to ranges if possible?)
>
>
> In D25425, make_pointee_iterator() is used to initialize the std::vector<>
> Overloads.
>
>
> On Sun, Oct 9, 2016 at 10:20 PM Justin Lebar via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
> jlebar created this revision.
>
> jlebar added a reviewer: timshen.
>
> jlebar added a subscriber: llvm-commits.
>
>
>
> https://reviews.llvm.org/D25418
>
>
>
> Files:
>
>   llvm/include/llvm/ADT/iterator.h
>
>   llvm/unittests/ADT/IteratorTest.cpp
>
>
>
> _______________________________________________
>
> llvm-commits mailing list
>
> llvm-commits at lists.llvm.org
>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161010/e1f3a9e3/attachment.html>


More information about the llvm-commits mailing list