<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Mon, Oct 10, 2016 at 11:51 AM David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">Perhaps a different phab review? I don't see it in that one (I see make_move_iterator used a few times there, though)</div></blockquote><div><br></div><div>Are yes, sorry, it should be D25422.</div><div><br></div><div>It's used to initialize a SmallVector, which does take a range.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Mon, Oct 10, 2016 at 11:48 AM Tim Shen <<a href="mailto:timshen@google.com" class="gmail_msg" target="_blank">timshen@google.com</a>> wrote:<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Mon, Oct 10, 2016 at 11:31 AM David Blaikie <<a href="mailto:dblaikie@gmail.com" class="gmail_msg" target="_blank">dblaikie@gmail.com</a>> wrote:<br class="gmail_msg"></div></div></div><div dir="ltr" class="gmail_msg"><div class="gmail_quote gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="gmail_msg">Do you have a use case for this that wouldn't be better off with a "make_pointe{e,r}_range"? (perhaps we can skip the make_*_iterator if we don't need them, and go straight to ranges if possible?)</div></blockquote><div class="gmail_msg"> </div></div></div><div dir="ltr" class="gmail_msg"><div class="gmail_quote gmail_msg"><div class="gmail_msg">In D25425, make_pointee_iterator() is used to initialize the std::vector<> Overloads.<br class="gmail_msg"></div></div></div><div dir="ltr" class="gmail_msg"><div class="gmail_quote gmail_msg"><div class="gmail_msg"><br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br class="gmail_msg"><div class="gmail_quote gmail_msg"></div><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">On Sun, Oct 9, 2016 at 10:20 PM Justin Lebar via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br class="gmail_msg"></div></div><div class="gmail_quote gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">jlebar created this revision.<br class="gmail_msg"><br class="gmail_msg">jlebar added a reviewer: timshen.<br class="gmail_msg"><br class="gmail_msg">jlebar added a subscriber: llvm-commits.<br class="gmail_msg"><br class="gmail_msg"><br class="gmail_msg"><br class="gmail_msg"><a href="https://reviews.llvm.org/D25418" rel="noreferrer" class="gmail_msg" target="_blank">https://reviews.llvm.org/D25418</a><br class="gmail_msg"><br class="gmail_msg"><br class="gmail_msg"><br class="gmail_msg">Files:<br class="gmail_msg"><br class="gmail_msg">  llvm/include/llvm/ADT/iterator.h<br class="gmail_msg"><br class="gmail_msg">  llvm/unittests/ADT/IteratorTest.cpp<br class="gmail_msg"><br class="gmail_msg"><br class="gmail_msg"></blockquote></div><div class="gmail_quote gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br class="gmail_msg">_______________________________________________<br class="gmail_msg"><br class="gmail_msg">llvm-commits mailing list<br class="gmail_msg"><br class="gmail_msg"><a href="mailto:llvm-commits@lists.llvm.org" class="gmail_msg" target="_blank">llvm-commits@lists.llvm.org</a><br class="gmail_msg"><br class="gmail_msg"><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" class="gmail_msg" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="gmail_msg"><br class="gmail_msg"></blockquote></div><br class="gmail_msg"></blockquote></div></div></blockquote></div><br></blockquote></div></div>