[PATCH] D25418: [ADT] Add make_pointe{e,r}_iterator.

[Justin Lebar via llvm-commits]

Unless there's a nice way to expand out a range for functions in the
stl that take ranges (like std::vector's constructor), it still seems
pretty valuable to me to have this.

Although this also somehow causes msvc to crash (?), so I'm going to
try to revert this patch for the moment.

http://lab.llvm.org:8011/builders/clang-x86-win2008-selfhost/builds/10739/steps/build%20stage%201/logs/stdio

On Mon, Oct 10, 2016 at 12:01 PM, Tim Shen <timshen at google.com> wrote:
> On Mon, Oct 10, 2016 at 11:51 AM David Blaikie <dblaikie at gmail.com> wrote:
>>
>> Perhaps a different phab review? I don't see it in that one (I see
>> make_move_iterator used a few times there, though)
>
>
> Are yes, sorry, it should be D25422.
>
> It's used to initialize a SmallVector, which does take a range.
>
>>
>>
>> On Mon, Oct 10, 2016 at 11:48 AM Tim Shen <timshen at google.com> wrote:
>>>
>>> On Mon, Oct 10, 2016 at 11:31 AM David Blaikie <dblaikie at gmail.com>
>>> wrote:
>>>>
>>>> Do you have a use case for this that wouldn't be better off with a
>>>> "make_pointe{e,r}_range"? (perhaps we can skip the make_*_iterator if we
>>>> don't need them, and go straight to ranges if possible?)
>>>
>>>
>>> In D25425, make_pointee_iterator() is used to initialize the
>>> std::vector<> Overloads.
>>>
>>>>
>>>> On Sun, Oct 9, 2016 at 10:20 PM Justin Lebar via llvm-commits
>>>> <llvm-commits at lists.llvm.org> wrote:
>>>>>
>>>>> jlebar created this revision.
>>>>>
>>>>> jlebar added a reviewer: timshen.
>>>>>
>>>>> jlebar added a subscriber: llvm-commits.
>>>>>
>>>>>
>>>>>
>>>>> https://reviews.llvm.org/D25418
>>>>>
>>>>>
>>>>>
>>>>> Files:
>>>>>
>>>>>   llvm/include/llvm/ADT/iterator.h
>>>>>
>>>>>   llvm/unittests/ADT/IteratorTest.cpp
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>>
>>>>> llvm-commits mailing list
>>>>>
>>>>> llvm-commits at lists.llvm.org
>>>>>
>>>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>>>
>>>>
>>
>