[PATCH] D25155: [Polly] Build and run isl_test as part of check-polly

[Tobias Grosser via llvm-commits]

grosser updated this revision to Diff 73306.
grosser added a comment.
Herald added a subscriber: modocache.

@meinersbur, I like the idea of running isl_test through lit and tried to
implement this.

I originally had hoped that I would manage to reuse one of the existing lit.cfg
instances, but did not find a good way to do so. I cannot use the existing unit
test lit instance, as the isl unit tests are not gtest based. I also cannot use
the normal polly tests, as this would mean we would run the isl unit tests with
each call to 'check-polly-tests', which would add 6 seconds of almost never
failing unit tests. I do not think this is what we want either.

Instead, I decided to create a new lit root which looks for .sh files. One of
these files runs ./isl_codegen. Even though this approach works, I am a little
unhappy with the verbose copy of lit.cfg and also just calling isl_codegen from
a shell file looks a little hacky. However, this approach seems to do exactly
what we want without the need for any isl modifications. Does this
implementation correspond with what you had in mind? Any ideas how this can
be further improved?

TODO: I still need to test this with out-of-tree builds of Polly.


https://reviews.llvm.org/D25155

Files:
  lib/External/CMakeLists.txt
  test/CMakeLists.txt
  test/UnitIsl/isl_test.sh
  test/UnitIsl/lit.cfg
  test/UnitIsl/lit.site.cfg.in

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D25155.73306.patch
Type: text/x-patch
Size: 10699 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161003/fafc5d21/attachment.bin>