[PATCH] D25155: [Polly] Build and run isl_test as part of check-polly

Michael Kruse via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 3 07:45:58 PDT 2016


Meinersbur added inline comments.


> CMakeLists.txt:299
> +add_custom_command(OUTPUT polly-run-isl-test
> +  COMMAND polly-isl-test > /dev/null
> +  WORKING_DIRECTORY ${ISL_SOURCE_DIR}

`> /dev/null` is platform-specific (not working on Windows). I also expected the redirection operator `>` to be escaped by `VERBATIM` st. is passes as command-line parameter, but it does not happen.

> isl_test.c:6716
> +
> +        printf("isl_test: All tests passed.");
>  	return 0;

Indention

https://reviews.llvm.org/D25155





More information about the llvm-commits mailing list