[PATCH] D25155: [Polly] Build and run isl_test as part of check-polly

[Tobias Grosser via llvm-commits]

grosser added a comment.

@brad.king: thanks for clarifying.

@meinersbur: Using lit is an interesting idea, I implemented this in the most recent patch.

I need to cross-check this patch (especially the Polly out-of-tree builds), but wanted to see if this new approach goes into the direction you thought of.



> Meinersbur wrote in CMakeLists.txt:299
> Cmake allows to change environment variables like this:
> 
>   COMMAND ${CMAKE_COMMAND} -E env srcdir="${ISL_SOURCE_DIR}" polly-isl-test

> Cmake allows to change environment variables like this:
> 
> COMMAND ${CMAKE_COMMAND} -E env srcdir="${ISL_SOURCE_DIR}" polly-isl-test

Does this work on Windows?

> "> /dev/null" is platform-specific (not working on Windows). I also expected the redirection operator > to be escaped by VERBATIM st. is passes as command-line parameter, but it does not happen.

I know. This is why I wrote in the commit message that I am looking for better solutions. Your proposal to use 'lit' addressed this issue, as lit does not reprint the output of individual test cases as long as they do not fail.

> Meinersbur wrote in isl_test.c:6698-6702
> Sure you want to change files in the External/isl directory? Previously, this was a no-go for you.

I certainly would upstream such changes BEFORE I commit this patch to Polly. However, before I start a discussion on the isl mailing list, I wanted to see if the approach I propose works well or if the Polly community has better ideas. As it seems easy to set environment variables from lit, this change does not seem to be needed any more. Thanks for pointing out the idea of using 'lit'.

https://reviews.llvm.org/D25155