[PATCH] D25155: [Polly] Build and run isl_test as part of check-polly

[Michael Kruse via llvm-commits]

Meinersbur added a comment.

I'd prefer to call it from the lit suite, like all the executables in `unittestts/`, for consistency. It would automatically count it as passed test and list it if it fails.  Should be possible by editing `lit.cfg`.



> CMakeLists.txt:298
>  
> +add_custom_command(OUTPUT polly-run-isl-test
> +  COMMAND polly-isl-test > /dev/null

This is no proper output. For commands without any output file, use

  add_custom_target(
    COMMAND ...

> CMakeLists.txt:299
> +add_custom_command(OUTPUT polly-run-isl-test
> +  COMMAND polly-isl-test > /dev/null
> +  WORKING_DIRECTORY ${ISL_SOURCE_DIR}

Cmake allows to change environment variables like this:

  COMMAND ${CMAKE_COMMAND} -E env srcdir="${ISL_SOURCE_DIR}" polly-isl-test

> isl_test.c:6698-6702
> +
> +        if (!srcdir) {
> +          printf("No isl source directory specified, assuming 'srcdir=.'.");
> +          srcdir = ".";
> +        }

Sure you want to change files in the External/isl directory? Previously, this was a no-go for you.

https://reviews.llvm.org/D25155