[PATCH] D20146: [PM] Port DSE to the new pass manager.

[Chandler Carruth via llvm-commits]

On Wed, May 11, 2016 at 12:46 PM Jake VanAdrighem via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> JakeVanAdrighem added inline comments.
>
> ================
> Comment at: include/llvm/Transforms/Scalar/DeadStoreElimination.h:57
> @@ +56,3 @@
> +
> +  bool runOnBasicBlock(BasicBlock &BB);
> +  bool MemoryIsNotModifiedBetween(Instruction *FirstI, Instruction
> *SecondI);
> ----------------
> davide wrote:
> > I think this should be a FunctionPass instead of a BasicBlockPass?
> DSE is a FunctionPass but the implementation works per BasicBlock.
>

And note that we explicitly dropped the complexity of having basic block
passes in the new PM. So I think it is correct for the legacy pass to be a
basic block pass and the new PM pass to be per-function.


>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D20146
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160511/fa89c103/attachment.html>