<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Wed, May 11, 2016 at 12:46 PM Jake VanAdrighem via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">JakeVanAdrighem added inline comments.<br>
<br>
================<br>
Comment at: include/llvm/Transforms/Scalar/DeadStoreElimination.h:57<br>
@@ +56,3 @@<br>
+<br>
+  bool runOnBasicBlock(BasicBlock &BB);<br>
+  bool MemoryIsNotModifiedBetween(Instruction *FirstI, Instruction *SecondI);<br>
----------------<br>
davide wrote:<br>
> I think this should be a FunctionPass instead of a BasicBlockPass?<br>
DSE is a FunctionPass but the implementation works per BasicBlock.<br></blockquote><div><br></div><div>And note that we explicitly dropped the complexity of having basic block passes in the new PM. So I think it is correct for the legacy pass to be a basic block pass and the new PM pass to be per-function.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="http://reviews.llvm.org/D20146" rel="noreferrer" target="_blank">http://reviews.llvm.org/D20146</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>