[PATCH] D20146: [PM] Port DSE to the new pass manager.

Jake VanAdrighem via llvm-commits llvm-commits at lists.llvm.org
Wed May 11 11:46:23 PDT 2016


JakeVanAdrighem added inline comments.

================
Comment at: include/llvm/Transforms/Scalar/DeadStoreElimination.h:57
@@ +56,3 @@
+
+  bool runOnBasicBlock(BasicBlock &BB);
+  bool MemoryIsNotModifiedBetween(Instruction *FirstI, Instruction *SecondI);
----------------
davide wrote:
> I think this should be a FunctionPass instead of a BasicBlockPass?
DSE is a FunctionPass but the implementation works per BasicBlock.


Repository:
  rL LLVM

http://reviews.llvm.org/D20146





More information about the llvm-commits mailing list