[PATCH] D18469: [LLVM] Fix Clang-tidy modernize-deprecated-headers warnings in some files; other minor fixes

[Eugene Zelenko via llvm-commits]

Eugene.Zelenko added inline comments.

================
Comment at: include/llvm-c/lto.h:766
@@ -775,2 +765,2 @@
 
-#endif
+#endif /* LLVM_C_LTO_H */
----------------
joker.eph wrote:
> clang-tidy does that? Sweet
I did this manually. Probably Clang-tidy llvm-header-guard could do this.

================
Comment at: include/llvm/ADT/Statistic.h:186
@@ -185,2 +185,2 @@
 
-#endif
+#endif // LLVM_ADT_STATISTIC_H
----------------
joker.eph wrote:
> Here it is `//` while the previous file was `/* ... */`, do you know why?
Previous file was supposed to be used in C code. This is clearly C++ one.

================
Comment at: include/llvm/DebugInfo/PDB/PDBTypes.h:18
@@ -18,1 +17,3 @@
+#include <cstdint>
+#include <cstring>
 
----------------
joker.eph wrote:
> why do we need cstring here? (You uploaded the patch without context, which makes it hard to figure here)
Because of strcpy().


Repository:
  rL LLVM

http://reviews.llvm.org/D18469