[PATCH] D18469: [LLVM] Fix Clang-tidy modernize-deprecated-headers warnings in some files; other minor fixes

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 18:54:07 PDT 2016

joker.eph accepted this revision.
joker.eph added a reviewer: joker.eph.
joker.eph added a comment.
This revision is now accepted and ready to land.

Assuming this does not break any build, LGTM.

Comment at: include/llvm-c/lto.h:766
@@ -775,2 +765,2 @@
+#endif /* LLVM_C_LTO_H */
clang-tidy does that? Sweet

Comment at: include/llvm/ADT/Statistic.h:186
@@ -185,2 +185,2 @@
Here it is `//` while the previous file was `/* ... */`, do you know why?

Comment at: include/llvm/DebugInfo/PDB/PDBTypes.h:18
@@ -18,1 +17,3 @@
+#include <cstdint>
+#include <cstring>
why do we need cstring here? (You uploaded the patch without context, which makes it hard to figure here)



More information about the llvm-commits mailing list