[PATCH] D18469: [LLVM] Fix Clang-tidy modernize-deprecated-headers warnings in some files; other minor fixes

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 24 19:03:55 PDT 2016

joker.eph added inline comments.

Comment at: include/llvm/DebugInfo/PDB/PDBTypes.h:18
@@ -18,1 +17,3 @@
+#include <cstdint>
+#include <cstring>
Eugene.Zelenko wrote:
> joker.eph wrote:
> > why do we need cstring here? (You uploaded the patch without context, which makes it hard to figure here)
> Because of strcpy().
Note sure if it is legit to have this in a header. This header is included in many many places!



More information about the llvm-commits mailing list