[PATCH] Switch the new COFF linker's symbol table to use a DenseMap of StringRefs. This uses the LLVM hashing rather than the standard library and a closed addressed hash table rather than chaining.

Sean Silva chisophugis at gmail.com
Wed Jun 24 19:16:37 PDT 2015

On Wed, Jun 24, 2015 at 9:18 AM, Rui Ueyama <ruiu at google.com> wrote:

> LGTM. Nice.
> One thing I want to mention is that the hash table used for the symbol
> table is append-only. We never remove any item from the hash table. All
> newly inserted keys are unique, so once a key-value pair is inserted, they
> will never change. Not sure if it helps you optimize it more (probably
> not), but that's an interesting property of the symbol table compared to
> other generic hash table uses.

Might deserve a comment in the source next to `Symtab`.

-- Sean Silva

> http://reviews.llvm.org/D10684
>   http://reviews.llvm.org/settings/panel/emailpreferences/
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150624/9400936e/attachment.html>

More information about the llvm-commits mailing list