<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jun 24, 2015 at 9:18 AM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">LGTM. Nice.<br>
<br>
One thing I want to mention is that the hash table used for the symbol table is append-only. We never remove any item from the hash table. All newly inserted keys are unique, so once a key-value pair is inserted, they will never change. Not sure if it helps you optimize it more (probably not), but that's an interesting property of the symbol table compared to other generic hash table uses.<br></blockquote><div><br></div><div>Might deserve a comment in the source next to `<span style="font-size:13px">Symtab`.</span></div><div><span style="font-size:13px"><br></span></div><div><span style="font-size:13px">-- Sean Silva</span></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10684&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=OCAivE4DWoBeJCNtC-bMcCCvt5RPkUN2-SmD_WKKz84&s=iuPMiYmgRLSe48LJ5iaIhOYvZokknD4KZTSSVsMReok&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D10684</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=OCAivE4DWoBeJCNtC-bMcCCvt5RPkUN2-SmD_WKKz84&s=7vOh2oGV-IySdhyM0Z2Sdgsdq7KAJqrnrRICKpgCVKE&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>