[PATCH] Switch the new COFF linker's symbol table to use a DenseMap of StringRefs. This uses the LLVM hashing rather than the standard library and a closed addressed hash table rather than chaining.

Rui Ueyama ruiu at google.com
Wed Jun 24 09:18:24 PDT 2015

LGTM. Nice.

One thing I want to mention is that the hash table used for the symbol table is append-only. We never remove any item from the hash table. All newly inserted keys are unique, so once a key-value pair is inserted, they will never change. Not sure if it helps you optimize it more (probably not), but that's an interesting property of the symbol table compared to other generic hash table uses.



More information about the llvm-commits mailing list