[PATCH] MIR Serialization: Print and parse simple machine function attributes and move the mir printing code out of the printing pass.

[Alex L]

2015-06-15 12:14 GMT-07:00 Duncan P. N. Exon Smith <dexonsmith at apple.com>:

>
> > On 2015-Jun-15, at 10:50, Alex Lorenz <arphaman at gmail.com> wrote:
> >
> > Hi dexonsmith, bob.wilson, bogner,
> >
> > This patch is based on the patch that connects MIRParser to the machine
> function analysis pass (http://reviews.llvm.org/D9928).
> >
> > This patch prints and parses the simple, scalar attributes of the
> machine function. It also moves the mir printing code out of the mir
> printing pass and into a separate file to allow it to be moved into a
> separate machineIR library in the future.
>
> Both changes LGTM, but they shouldn't be bundled up like this.
>
> Please commit the code reorganization first, and then add the new
> features in a second (separate) commit.
>

Thanks, I will do that.


>
> >
> > REPOSITORY
> >  rL LLVM
> >
> > http://reviews.llvm.org/D10449
> >
> > Files:
> >  include/llvm/CodeGen/MIRYamlMapping.h
> >  lib/CodeGen/CMakeLists.txt
> >  lib/CodeGen/MIRParser/MIRParser.cpp
> >  lib/CodeGen/MIRPrinter.cpp
> >  lib/CodeGen/MIRPrinter.h
> >  lib/CodeGen/MIRPrintingPass.cpp
> >  test/CodeGen/MIR/machine-function.mir
> >
> > EMAIL PREFERENCES
> >  http://reviews.llvm.org/settings/panel/emailpreferences/
> > <D10449.27687.patch>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150615/41e54ffe/attachment.html>