[PATCH] MIR Serialization: Print and parse simple machine function attributes and move the mir printing code out of the printing pass.

Duncan P. N. Exon Smith dexonsmith at apple.com
Mon Jun 15 12:14:41 PDT 2015

> On 2015-Jun-15, at 10:50, Alex Lorenz <arphaman at gmail.com> wrote:
> Hi dexonsmith, bob.wilson, bogner,
> This patch is based on the patch that connects MIRParser to the machine function analysis pass (http://reviews.llvm.org/D9928).
> This patch prints and parses the simple, scalar attributes of the machine function. It also moves the mir printing code out of the mir printing pass and into a separate file to allow it to be moved into a separate machineIR library in the future.

Both changes LGTM, but they shouldn't be bundled up like this.

Please commit the code reorganization first, and then add the new
features in a second (separate) commit.

>  rL LLVM
> http://reviews.llvm.org/D10449
> Files:
>  include/llvm/CodeGen/MIRYamlMapping.h
>  lib/CodeGen/CMakeLists.txt
>  lib/CodeGen/MIRParser/MIRParser.cpp
>  lib/CodeGen/MIRPrinter.cpp
>  lib/CodeGen/MIRPrinter.h
>  lib/CodeGen/MIRPrintingPass.cpp
>  test/CodeGen/MIR/machine-function.mir
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> <D10449.27687.patch>

More information about the llvm-commits mailing list