<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2015-06-15 12:14 GMT-07:00 Duncan P. N. Exon Smith <span dir="ltr"><<a href="mailto:dexonsmith@apple.com" target="_blank">dexonsmith@apple.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
> On 2015-Jun-15, at 10:50, Alex Lorenz <<a href="mailto:arphaman@gmail.com">arphaman@gmail.com</a>> wrote:<br>
><br>
> Hi dexonsmith, bob.wilson, bogner,<br>
><br>
> This patch is based on the patch that connects MIRParser to the machine function analysis pass (<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D9928&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=sZcQ858-Y5UcFDHdeGttpGn_cYRGzNPRi1Zz4ulTUmE&s=FW2m5DL-G7xh6SFxaHhnp9B6v8m-rtQ5VVuZNMpxARI&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D9928</a>).<br>
><br>
> This patch prints and parses the simple, scalar attributes of the machine function. It also moves the mir printing code out of the mir printing pass and into a separate file to allow it to be moved into a separate machineIR library in the future.<br>
<br>
</span>Both changes LGTM, but they shouldn't be bundled up like this.<br>
<br>
Please commit the code reorganization first, and then add the new<br>
features in a second (separate) commit.<br></blockquote><div><br></div><div>Thanks, I will do that.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class=""><br>
><br>
> REPOSITORY<br>
>  rL LLVM<br>
><br>
> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10449&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=sZcQ858-Y5UcFDHdeGttpGn_cYRGzNPRi1Zz4ulTUmE&s=Qo7oKpAthnKC5d6Ro-o3EYNs-y1GHMMeRAbdtzyj12Y&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/D10449</a><br>
><br>
> Files:<br>
>  include/llvm/CodeGen/MIRYamlMapping.h<br>
>  lib/CodeGen/CMakeLists.txt<br>
>  lib/CodeGen/MIRParser/MIRParser.cpp<br>
>  lib/CodeGen/MIRPrinter.cpp<br>
>  lib/CodeGen/MIRPrinter.h<br>
>  lib/CodeGen/MIRPrintingPass.cpp<br>
>  test/CodeGen/MIR/machine-function.mir<br>
><br>
> EMAIL PREFERENCES<br>
>  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=sZcQ858-Y5UcFDHdeGttpGn_cYRGzNPRi1Zz4ulTUmE&s=Hj8o5WkTAbihTn-w_7LDKm97w91wB4OsyIYR9R1jtPw&e=" rel="noreferrer" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
</span>> <D10449.27687.patch><br>
<br>
</blockquote></div><br></div></div>