[PATCH] Get the LLVM_ENABLE_MODULES build going for LLVM

Chris Bieneman beanz at apple.com
Mon Jun 15 11:27:39 PDT 2015


LGTM.

It isn’t necessarily ideal that we are making everything rely on intrinsics_gen in order to get the module_map, but I don’t see a way around that at the moment.

-Chris

> On Jun 9, 2015, at 4:52 PM, Sean Silva <chisophugis at gmail.com> wrote:
> 
> +Chapuni, for the CMake stuff.
> 
> -- Sean Silva
> 
> On Tue, Jun 9, 2015 at 1:58 PM, Duncan P. N. Exon Smith <dexonsmith at apple.com <mailto:dexonsmith at apple.com>> wrote:
> These changes collectively get LLVM building with
> -DLLVM_ENABLE_MODULES=ON using Xcode 7 beta as the host compiler.
> 
> I imagine this patch would help out the very red
> http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules <https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8011_builders_clang-2Dx86-5F64-2Dlinux-2Dselfhost-2Dmodules&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=upgCQmtSm1t2_dLEH9cgq8dQgJWnuVH5kR5i5_cDFIk&s=wra7cQjJi9Ao4Cq9oXwnM-14nY3h8x0MlCH7qSxJWms&e=>
> a little, although I only went as far as LLVM locally.
> 
> I'll split this up before commit, but I wouldn't mind a quick check that
> I'm fixing things "correctly".  In particular, most libraries now depend
> on `intrinsics_gen` to ensure that llvm/IR/Intrinsics.gen gets built
> before anyone includes the LLVM_IR module (I found the complete list by
> inserting a compile error in TableGen.cpp and running `ninja -k 2` until
> that was the only error).  Is there a better way to represent this
> dependency?
> 
> Also, is there any reason LLVM_ENABLE_MODULES isn't documented at
> http://llvm.org/docs/CMake.html <https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_docs_CMake.html&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=upgCQmtSm1t2_dLEH9cgq8dQgJWnuVH5kR5i5_cDFIk&s=bKZOsCE7mLtTY0vOjlEien4r7GnKwzDhDn2QzDoYtH8&e=>
> ?
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits <http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150615/d241fe45/attachment.html>


More information about the llvm-commits mailing list