<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">LGTM.<div class=""><br class=""></div><div class="">It isn’t necessarily ideal that we are making everything rely on intrinsics_gen in order to get the module_map, but I don’t see a way around that at the moment.</div><div class=""><br class=""></div><div class="">-Chris</div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Jun 9, 2015, at 4:52 PM, Sean Silva <<a href="mailto:chisophugis@gmail.com" class="">chisophugis@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">+Chapuni, for the CMake stuff.<div class=""><br class=""></div><div class=""><div class="">-- Sean Silva</div></div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Jun 9, 2015 at 1:58 PM, Duncan P. N. Exon Smith <span dir="ltr" class=""><<a href="mailto:dexonsmith@apple.com" target="_blank" class="">dexonsmith@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">These changes collectively get LLVM building with<br class="">
-DLLVM_ENABLE_MODULES=ON using Xcode 7 beta as the host compiler.<br class="">
<br class="">
I imagine this patch would help out the very red<br class="">
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8011_builders_clang-2Dx86-5F64-2Dlinux-2Dselfhost-2Dmodules&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=upgCQmtSm1t2_dLEH9cgq8dQgJWnuVH5kR5i5_cDFIk&s=wra7cQjJi9Ao4Cq9oXwnM-14nY3h8x0MlCH7qSxJWms&e=" target="_blank" class="">http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules</a><br class="">
a little, although I only went as far as LLVM locally.<br class="">
<br class="">
I'll split this up before commit, but I wouldn't mind a quick check that<br class="">
I'm fixing things "correctly". In particular, most libraries now depend<br class="">
on `intrinsics_gen` to ensure that llvm/IR/Intrinsics.gen gets built<br class="">
before anyone includes the LLVM_IR module (I found the complete list by<br class="">
inserting a compile error in TableGen.cpp and running `ninja -k 2` until<br class="">
that was the only error). Is there a better way to represent this<br class="">
dependency?<br class="">
<br class="">
Also, is there any reason LLVM_ENABLE_MODULES isn't documented at<br class="">
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_docs_CMake.html&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=upgCQmtSm1t2_dLEH9cgq8dQgJWnuVH5kR5i5_cDFIk&s=bKZOsCE7mLtTY0vOjlEien4r7GnKwzDhDn2QzDoYtH8&e=" target="_blank" class="">http://llvm.org/docs/CMake.html</a><br class="">
?<br class="">
<br class="">
<br class="">_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@cs.uiuc.edu" class="">llvm-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br class="">
<br class=""></blockquote></div><br class=""></div>
_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@cs.uiuc.edu" class="">llvm-commits@cs.uiuc.edu</a><br class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br class=""></div></blockquote></div><br class=""></div></body></html>