[PATCH] Get the LLVM_ENABLE_MODULES build going for LLVM

Duncan P. N. Exon Smith dexonsmith at apple.com
Mon Jun 15 17:51:31 PDT 2015


Thanks.  Committed the other changes in r239793 and r239794, and
the `intrinsics_gen` part in r239796.  I'm hoping this unbricks the
bot:

http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules

(Hoping to set one up on Green Dragon soon!)

> On 2015-Jun-15, at 11:27, Chris Bieneman <beanz at apple.com> wrote:
> 
> LGTM.
> 
> It isn’t necessarily ideal that we are making everything rely on intrinsics_gen in order to get the module_map, but I don’t see a way around that at the moment.
> 
> -Chris
> 
>> On Jun 9, 2015, at 4:52 PM, Sean Silva <chisophugis at gmail.com> wrote:
>> 
>> +Chapuni, for the CMake stuff.
>> 
>> -- Sean Silva
>> 
>> On Tue, Jun 9, 2015 at 1:58 PM, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
>> These changes collectively get LLVM building with
>> -DLLVM_ENABLE_MODULES=ON using Xcode 7 beta as the host compiler.
>> 
>> I imagine this patch would help out the very red
>> http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules
>> a little, although I only went as far as LLVM locally.
>> 
>> I'll split this up before commit, but I wouldn't mind a quick check that
>> I'm fixing things "correctly".  In particular, most libraries now depend
>> on `intrinsics_gen` to ensure that llvm/IR/Intrinsics.gen gets built
>> before anyone includes the LLVM_IR module (I found the complete list by
>> inserting a compile error in TableGen.cpp and running `ninja -k 2` until
>> that was the only error).  Is there a better way to represent this
>> dependency?
>> 
>> Also, is there any reason LLVM_ENABLE_MODULES isn't documented at
>> http://llvm.org/docs/CMake.html
>> ?
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 





More information about the llvm-commits mailing list