[PATCH] LibDriver, llvm-lib: introduce.

[Sean Silva]

On Tue, Jun 9, 2015 at 2:31 PM, Rafael Ávila de Espíndola <
rafael.espindola at gmail.com> wrote:

> This is fine from the llvm side.
>
> Rui, is this a convenient interface for lld to use?
>
>
> ================
> Comment at: lib/LibDriver/LibDriver.cpp:71
> @@ +70,3 @@
> +namespace {
> +class StrDupSaver : public cl::StringSaver {
> +  std::vector<char *> Dups;
> ----------------
> We really should just move the string saver that rui implemented to llvm
> and make it the one true string saver.
> At least add a fixme about that.
>


I tried doing something similar at one point. IIRC the main stumbling block
was a StringSaver that gets called under a lock in LLD for .drective, which
was hard to disentangle for some reason.

llvm: r215784, 215790
clang: r215761, r215785, r215791

There are quite a few knock-on simplifications allowed by doing this,
detailed in the commit message for r215784.

-- Sean Silva


>
> http://reviews.llvm.org/D10297
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150609/e6d5ea07/attachment.html>