[PATCH] LibDriver, llvm-lib: introduce.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Jun 9 17:43:25 PDT 2015


> I tried doing something similar at one point. IIRC the main stumbling block
> was a StringSaver that gets called under a lock in LLD for .drective, which
> was hard to disentangle for some reason.

I just noticed that.

Rui, do you remember why the lock was needed? Isn't the allocation
itself thread safe? Would it be sufficient to pass in an allocator
that used a std::mutex in Allocate?

I have attached the work in progress patches (builds and all tests pass).

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm.patch
Type: application/octet-stream
Size: 6241 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150609/da3aa502/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang.patch
Type: application/octet-stream
Size: 1690 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150609/da3aa502/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lld.patch
Type: application/octet-stream
Size: 11553 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150609/da3aa502/attachment-0002.obj>


More information about the llvm-commits mailing list