<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jun 9, 2015 at 2:31 PM, Rafael Ávila de Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">This is fine from the llvm side.<br>
<br>
Rui, is this a convenient interface for lld to use?<br>
<br>
<br>
================<br>
Comment at: lib/LibDriver/LibDriver.cpp:71<br>
@@ +70,3 @@<br>
+namespace {<br>
+class StrDupSaver : public cl::StringSaver {<br>
+  std::vector<char *> Dups;<br>
----------------<br>
We really should just move the string saver that rui implemented to llvm and make it the one true string saver.<br>
At least add a fixme about that.<br></blockquote><div><br></div><div><br></div><div>I tried doing something similar at one point. IIRC the main stumbling block was a StringSaver that gets called under a lock in LLD for .drective, which was hard to disentangle for some reason.</div><div><br></div><div>llvm: r215784, 215790</div><div>clang: r215761, r215785, r215791<br></div><div><br></div><div>There are quite a few knock-on simplifications allowed by doing this, detailed in the commit message for r215784.</div><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span class="im"><br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10297&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=wKSm-mJtAwwVtFAf3dKs2KpFUsDLufR8_-JhNY0hPtM&s=iSliX6zwFRSWljzS2c1emKQA1yGLYJUcNovJn8TaU2Y&e=" target="_blank">http://reviews.llvm.org/D10297</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=wKSm-mJtAwwVtFAf3dKs2KpFUsDLufR8_-JhNY0hPtM&s=5iNZ2CiLF_YNRYA978NyPEI1b3pvUAq2GDHYz-y4rMA&e=" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
<br>
</span><div class=""><div class="h5">_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div>