[AVX512] Add masking variants for vextract*x4
anemet at apple.com
Wed Oct 1 10:38:24 PDT 2014
On Oct 1, 2014, at 9:30 AM, Robert Khasanov <rob.khasanov at gmail.com> wrote:
> Hi Adam,
> About maskings in vextract*x4 instructions. I think we can include VK4 register class and v4i1 type for AVX512F subset as it is needed by instruction semantics. Elena, do you agree? It would be better keep all intrinsics lowering in one place.
I don’t think that a single intrinsic is worth the complication at this point. I agree that this should be the long term direction but for now it’s probably easier to keep the current simple model in mind that AVX512f only requires v8i1 and above. So all the strangeness about v4i1 e.g. that it cannot be casted directly from a scalar type, etc. are kept to AVX512vl.
Once we figure all that out for AVX512vl we will know if it’s worth bringing it into the AVX512f world (for the sake of a single intrinsic or perhaps for some other reason I don’t yet know).
So my preference would keep the asm-only masking ops for now and experiment with v4i1 in AVX512f context at a later point. Is that acceptable?
> 0001: LGTM, anyway. It should be committed even though we decided to include VK4 register class for AVX512F subset, because it would be helpful for other instructions (e.g. CMP that will override masking patterns)
Yeah, I was hoping you’d notice that ;).
> 0004: I don't understand why you use "AVX512_masking_asm_only" naming. It's not obvious from this name that only non-masking pattern is used.
Do you have a better suggestion? What I was trying to express that for the masking variants we only provide asm support and no code-gen. Is your problem that the name is too masking focused, i.e. that for the non-masking we do provide code-gen?
Perhaps I should rename these classes to AVX512_maskable or something and call this guy AVX512_maskable_asm_masking?
> 2014-10-01 17:47 GMT+04:00 Demikhovsky, Elena <elena.demikhovsky at intel.com>:
> 0003 : LGTM
> - Elena
> -----Original Message-----
> From: Adam Nemet [mailto:anemet at apple.com]
> Sent: Wednesday, October 01, 2014 08:57
> To: Demikhovsky, Elena; Robert Khasanov
> Cc: LLVM Commits
> Subject: [AVX512] Add masking variants for vextract*x4
> Hi Elena and Robert,
> First I tried to implement this with the usual intrinsic lowering but unfortunately because vextract*x4 produces v4* vectors I would have needed VK4 and v4i1 for masking in AVX512f which only come with AVX512vl. I don't think these intrinsics are worth the hassle making that work so instead I went for asm-only instructions. Then I have the intrinsics Pat<>s to call the corresponding instruction.
> This approach gave me a chance to incorporate asm-only masking support into the AVX512_masking hierarchy. See patch 1 and 4.
> Also the masking operand was not supported with the MRMDestReg format, so I've added that too. See patch 2.
> Please let me know if it looks good to you.
> Intel Israel (74) Limited
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits