[PATCH] PR19958 wrong code at -O1 and above on x86_64-linux-gnu (InstCombine)

[suyog sarda]

+ Duncan

(I have run clang-format on the code :))


On Sun, Jul 13, 2014 at 10:38 PM, suyog <suyog.sarda at samsung.com> wrote:

> Hi Duncan,
>
> Made changes as per your suggestions :
> - Wrote the whole logic in separate function.
>   Didn't make it 'static', took 'cue' from other 'Foldicmp' functions.
> - Removed TODO, will probably raise a separate PR for it.
> - Updated comments, removed extra braces.
> - defined variables just before their use.
>
> Can you please see if this looks good to you?
> Your comments/suggestions are most welcomed.
>
> Thanks,
> Suyog
>
> http://reviews.llvm.org/D4068
>
> Files:
>   lib/Transforms/InstCombine/InstCombine.h
>   lib/Transforms/InstCombine/InstCombineCompares.cpp
>   test/Transforms/InstCombine/icmp-shr.ll
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>


-- 
With regards,
Suyog Sarda
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140713/f99bd9db/attachment.html>