<div dir="ltr"><div>+ Duncan<br><br></div>(I have run clang-format on the code :))<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Jul 13, 2014 at 10:38 PM, suyog <span dir="ltr"><<a href="mailto:suyog.sarda@samsung.com" target="_blank">suyog.sarda@samsung.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Duncan,<br>
<br>
Made changes as per your suggestions :<br>
- Wrote the whole logic in separate function.<br>
  Didn't make it 'static', took 'cue' from other 'Foldicmp' functions.<br>
- Removed TODO, will probably raise a separate PR for it.<br>
- Updated comments, removed extra braces.<br>
- defined variables just before their use.<br>
<br>
Can you please see if this looks good to you?<br>
Your comments/suggestions are most welcomed.<br>
<div class=""><br>
Thanks,<br>
Suyog<br>
<br>
<a href="http://reviews.llvm.org/D4068" target="_blank">http://reviews.llvm.org/D4068</a><br>
<br>
Files:<br>
</div>  lib/Transforms/InstCombine/InstCombine.h<br>
  lib/Transforms/InstCombine/InstCombineCompares.cpp<br>
  test/Transforms/InstCombine/icmp-shr.ll<br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br><br clear="all"><br>-- <br>With regards,<br>Suyog Sarda<br>
</div>