[PATCH] PR19958 wrong code at -O1 and above on x86_64-linux-gnu (InstCombine)
suyog.sarda at samsung.com
Sun Jul 13 10:08:31 PDT 2014
Made changes as per your suggestions :
- Wrote the whole logic in separate function.
Didn't make it 'static', took 'cue' from other 'Foldicmp' functions.
- Removed TODO, will probably raise a separate PR for it.
- Updated comments, removed extra braces.
- defined variables just before their use.
Can you please see if this looks good to you?
Your comments/suggestions are most welcomed.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 20640 bytes
Desc: not available
More information about the llvm-commits