[llvm] r210414 - Do materialize for floating point

Chandler Carruth chandlerc at google.com
Sun Jun 8 11:36:42 PDT 2014


On Sun, Jun 8, 2014 at 8:04 AM, Daniel Sanders <Daniel.Sanders at imgtec.com>
wrote:

> Hi All,
>
>
>
> Reed, please don't re-commit until you understand and make the requested
> change that the LGTM was conditional on. I'll add an explanation to the
> review.
>
>
>
> I think Alp did the right thing by reverting the commit. He had serious
> concerns about the patch, the review, and whether the process had been
> followed. It's important to note that the commit message is at least as
> important than the content. People should be able to read the commit
> message and form opinions on what the commit does and why. One important
> misconception I need to clear up here is that there's no such thing as an
> 'authorized llvm Mips maintainer'. The developer policy only distinguishes
> between those who maintain/contributed the relevant code and those who
> don't/didn't. In this case, the question of maintainer/contributor is
> irrelevant since everybody has the same rights to 'make obvious changes'
> such as reverting an 'obviously bad commit'.
>

Here here!!!!

I want to second this and put it on a big sign. =D

No backend in the LLVM tree is "special" or gets to follow different rules
from any other part of the LLVM project. When bad patches go in, folks
revert them. Alp did a great job of saying why, getting the tree cleaned
up, while ensuring the impacted author was informed of what was going on.
Daniel, you've done a great job of helping clarify things.

I also want to endorse "conditional LGTM" that you were using Daniel. We do
this all the time and it is essential, as you say, to cope with the
inherent decentralization and timezone spread we have in an open source
project. It does rely on one thing: developers with commit privileges need
to work very hard to make sure that they are respecting it. If they have
any doubt, they need to wait and confirm so that we don't undermine the
review process when trying to expedite it.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140608/a6606334/attachment.html>


More information about the llvm-commits mailing list