[llvm] r210414 - Do materialize for floating point

Chandler Carruth chandlerc at google.com
Sun Jun 8 11:29:55 PDT 2014


On Sun, Jun 8, 2014 at 9:15 AM, Alp Toker <alp at nuanti.com> wrote:

> Indeed Phabricator might be adding to the confusion. It seems to create
> very "human" commit logs where it's difficult to tell a script generated
> the text. It looks like the author has written the commit log, applied an
> explicit sign-off and landed the patch whereas I'm starting to get the
> impression the script is building these commit logs and making it easy to
> generate bogus commits with a single keystroke.
>
> If so, it might be an idea to go easy on the Phabricator until it gets
> fixed, rather that the other way round.
>

To try and clarify something which you're already hinting at here Alp...

Phabricator is a *tool* which *aids* the commit process. It is not policy,
and bugs or features in it should never be taken to dictate how a review
should proceed.

The only source of policy and the definition of the acceptable process is,
as always: http://llvm.org/docs/DeveloperPolicy.html


I'm going to send an email expounding on this to llvmdev as well because
there seems to be persistent confusion about this.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140608/2a9b0e2a/attachment.html>


More information about the llvm-commits mailing list