[PATCH] AsmParser: add support for .end directive
renato.golin at linaro.org
Mon Dec 16 12:07:22 PST 2013
On 16 December 2013 17:13, Saleem Abdulrasool <compnerd at compnerd.org> wrote:
> That was in the commit message: the glaring problem with this
> implantation is that the flush is a huge sore thumb. I wasn't sure if it
> is worth adding a discard buffer call. I figured that adding that later is
> definitely possible so I would keep the patch simple.
Ok, I seem to have misread that, too... It was too early in the morning,
I think it depends if there are any side effects to calling Lex() that
wouldn't be done with a Discard() (like counting number of tokens or
something like that). I don't really know, Clang folks can make sure you're
not invalidating any premise, but I'd vote in favour of a new discard
I was being goofy. I can change it if you want.
No, that's ok, I was just unaware of the tarp meme. ;)
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits