[PATCH] AsmParser: add support for .end directive
compnerd at compnerd.org
Mon Dec 16 09:13:47 PST 2013
On Monday, December 16, 2013, Renato Golin wrote:
> Oh, I was looking at the wrong place!
> I got so used to assume the ARM directives were the GNU directives that
> I didn't bother checking the URL... ;)
> On a related comment, isn't there a better way to flush the rest of the
> lexer instead of consuming every remaining token?
That was in the commit message: the glaring problem with this implantation
is that the flush is a huge sore thumb. I wasn't sure if it is worth
adding a discard buffer call. I figured that adding that later is
definitely possible so I would keep the patch simple.
> Comment at: test/MC/AsmParser/directive_end.s:6
> @@ +5,3 @@
> + int $0x3
> is this a typo or a pun?
I was being goofy. I can change it if you want.
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits